Add declaration tests for WGSL immediate variables#4661
Open
shaoboyan091 wants to merge 4 commits into
Open
Conversation
shaoboyan091
force-pushed
the
pr/immediate-declaration-validation
branch
from
7a7b534 to
a466dea
Compare
|
Results for build job (at 5e77072): -webgpu:shader,validation,decl,context_dependent_resolution:language_names:* - 4 cases, 12 subcases (~3/case)
+webgpu:shader,validation,decl,context_dependent_resolution:language_names:* - 5 cases, 15 subcases (~3/case)
+webgpu:shader,validation,decl,immediate:store_type,valid:* - 10 cases, 10 subcases (~1/case)
+webgpu:shader,validation,decl,immediate:store_type,invalid:* - 11 cases, 11 subcases (~1/case)
+webgpu:shader,validation,decl,immediate:scope:* - 2 cases, 2 subcases (~1/case)
+webgpu:shader,validation,decl,immediate:binding_attributes:* - 4 cases, 4 subcases (~1/case)
+webgpu:shader,validation,decl,immediate:access_mode:* - 4 cases, 4 subcases (~1/case)
+webgpu:shader,validation,decl,immediate:entry_point_interface:* - 5 cases, 5 subcases (~1/case)
+webgpu:shader,validation,decl,immediate:pointers:* - 8 cases, 8 subcases (~1/case)
-webgpu:shader,validation,decl,var:module_scope_types:* - 406 cases, 406 subcases (~1/case)
+webgpu:shader,validation,decl,var:module_scope_types:* - 464 cases, 464 subcases (~1/case)
-webgpu:shader,validation,decl,var:binding_point_on_non_resources:* - 8 cases, 8 subcases (~1/case)
+webgpu:shader,validation,decl,var:binding_point_on_non_resources:* - 12 cases, 12 subcases (~1/case)
-webgpu:shader,validation,decl,var:address_space_access_mode:* - 40 cases, 40 subcases (~1/case)
+webgpu:shader,validation,decl,var:address_space_access_mode:* - 48 cases, 48 subcases (~1/case)
-TOTAL: 283229 cases, 2325040 subcases
+TOTAL: 283344 cases, 2325157 subcases |
This patch adds a focused declaration suite for `var<immediate>`. The new tests cover accepted scalar, vector, matrix, and struct store types, rejected store types, module-scope-only declarations, rejection of binding attributes, rejection of explicit access modes, and the one-immediate-variable-per-entry-point rule. It also threads `immediate` through the existing declaration tests so the generic address space coverage checks the same declaration access rules as storage, uniform, private, workgroup, and function variables. The context-dependent resolution table now recognizes `immediate_address_space` as a language feature name.
shaoboyan091
force-pushed
the
pr/immediate-declaration-validation
branch
from
a466dea to
a3c267f
Compare
Contributor
Author
|
@jrprice PTAL, catch a potential "issue" in chrome canary, it seems canary supported fixed array in immediate address space but the spec said it shouldn't. Fixed array could be supported in implementation but it doesn't be discussed in community yet. |
Contributor
Author
|
@jrprice softly ping for reviewing, thanks! |
dj2
reviewed
Jun 15, 2026
The WGSL spec allows f16 in the immediate address space: f16 is a host-shareable constructible scalar, and immediate store types only exclude arrays and structures containing arrays. Remove the f16 immediate skip so the validation tests assert the spec-correct result (f16 immediate compiles). An implementation that rejects f16 immediate is non-conformant and will be flagged by these tests.
The WGSL spec is restricting f16 in the immediate address space (gpuweb/gpuweb#6297), so move f16 and vec3h to the rejected immediate store types and exclude f16 types from the accepted immediate store types in the shared module-scope coverage. Simplify the scope test to declare the variable at function scope for both cases and vary only the address space, using the function address space as the control. Module-scope validity is already covered by the module_scope_types test.
Member
|
Discussing internally, we think |
Contributor
Author
Good to know this. F16 is important. |
The WGSL spec allows f16 in the immediate address space, so f16 and vec3h are valid immediate store types and are expected to compile. No skip is added for implementations that reject f16 immediate data; an implementation that does so is non-conformant, and these tests flag it.
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a focused declaration suite for
var<immediate>.The new tests cover accepted scalar, vector, matrix, and struct store types, rejected store types, module-scope-only declarations, rejection of binding attributes, rejection of explicit access modes, and the one-immediate-variable-per-entry-point rule.
It also threads
immediatethrough the existing declaration tests so the generic address space coverage checks the same declaration access rules as storage, uniform, private, workgroup, and function variables. The context-dependent resolution table now recognizesimmediate_address_spaceas a language feature name.Notes for reviewers:
immediate_address_spaceWGSL language feature, so they run only where therequires immediate_address_space;shaders can compile (not merely where the immediate API surface is exposed).f16/vec3hare treated as valid immediate store types (host-shareable and constructible, gated onshader-f16), consistent with howuniformaccepts them.Issue: #
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off: